Skip to content

[OPS-SCRIPTS] use Safe API kit for gov actions#2126

Merged
d10r merged 1 commit intodevfrom
2025-12-safe_api_kit
Jan 7, 2026
Merged

[OPS-SCRIPTS] use Safe API kit for gov actions#2126
d10r merged 1 commit intodevfrom
2025-12-safe_api_kit

Conversation

@d10r
Copy link
Collaborator

@d10r d10r commented Dec 18, 2025

The previous version stopped working, always failing with

Error: Too Many Requests
    at sendRequest (/home/didi/src/sf/protocol-monorepo/node_modules/@safe-global/safe-service-client/src/utils/httpRequests.ts:52:9)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at SafeServiceClient.getNextNonce (/home/didi/src/sf/protocol-monorepo/node_modules/@safe-global/safe-service-client/src/SafeServiceClient.ts:566:22)
    at executeSafeTransaction (/home/didi/src/sf/protocol-monorepo/packages/ethereum-contracts/ops-scripts/libs/common.js:412:23)

This is solved by using an API key, but that required an SDK update.

A positive side effect is that we don't need to keep a list of per-chain api url, it's now unified.

@github-actions
Copy link

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@d10r d10r marked this pull request as ready for review December 18, 2025 19:03
@d10r d10r requested a review from hellwolf as a code owner December 18, 2025 19:03
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@d10r d10r merged commit 45cf768 into dev Jan 7, 2026
30 checks passed
@d10r d10r deleted the 2025-12-safe_api_kit branch January 7, 2026 09:59
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

XKCD Comic Relif

Link: https://xkcd.com/2126
https://xkcd.com/2126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants